Remove missing todos #1055

edg-l · 2025-01-16T15:21:15Z

Checklist

Linked to Github Issue
Unit tests added
Integration tests added.
This change requires new documentation.
- Documentation has been added/updated.

github-actions · 2025-01-16T15:51:33Z

Benchmark results Main vs HEAD.

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_insert.cairo (JIT)`	3.937 ± 0.017	3.912	3.968	1.00
`base dict_insert.cairo (AOT)`	4.171 ± 0.031	4.121	4.210	1.06 ± 0.01

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head dict_insert.cairo (JIT)`	4.251 ± 0.045	4.152	4.307	1.00
`head dict_insert.cairo (AOT)`	4.426 ± 0.028	4.373	4.474	1.04 ± 0.01

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_snapshot.cairo (JIT)`	3.891 ± 0.018	3.863	3.915	1.00
`base dict_snapshot.cairo (AOT)`	3.967 ± 0.021	3.945	4.009	1.02 ± 0.01

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head dict_snapshot.cairo (JIT)`	4.085 ± 0.039	4.009	4.129	1.00
`head dict_snapshot.cairo (AOT)`	4.245 ± 0.026	4.214	4.287	1.04 ± 0.01

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base factorial_2M.cairo (JIT)`	4.153 ± 0.026	4.108	4.185	1.00
`base factorial_2M.cairo (AOT)`	4.380 ± 0.035	4.332	4.432	1.05 ± 0.01

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head factorial_2M.cairo (JIT)`	4.452 ± 0.040	4.414	4.556	1.00
`head factorial_2M.cairo (AOT)`	4.661 ± 0.045	4.584	4.729	1.05 ± 0.01

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base fib_2M.cairo (JIT)`	3.724 ± 0.051	3.661	3.807	1.00
`base fib_2M.cairo (AOT)`	3.921 ± 0.050	3.855	4.002	1.05 ± 0.02

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head fib_2M.cairo (JIT)`	3.990 ± 0.038	3.914	4.031	1.00
`head fib_2M.cairo (AOT)`	4.228 ± 0.041	4.152	4.289	1.06 ± 0.01

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search.cairo (JIT)`	3.904 ± 0.034	3.874	3.977	1.00
`base linear_search.cairo (AOT)`	3.985 ± 0.044	3.942	4.096	1.02 ± 0.01

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head linear_search.cairo (JIT)`	4.160 ± 0.042	4.082	4.233	1.00
`head linear_search.cairo (AOT)`	4.290 ± 0.046	4.211	4.347	1.03 ± 0.02

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base logistic_map.cairo (JIT)`	3.966 ± 0.016	3.936	3.996	1.00
`base logistic_map.cairo (AOT)`	4.056 ± 0.022	4.030	4.097	1.02 ± 0.01

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head logistic_map.cairo (JIT)`	4.258 ± 0.034	4.190	4.319	1.00
`head logistic_map.cairo (AOT)`	4.359 ± 0.040	4.299	4.438	1.02 ± 0.01

github-actions · 2025-01-16T16:01:56Z

Benchmarking results

Benchmark for program `dict_insert`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	21.379 ± 0.193	21.164	21.693	99.71 ± 2.53
`cairo-native (embedded AOT)`	4.135 ± 0.050	4.078	4.215	19.29 ± 0.51
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.942 ± 0.026	3.906	3.989	18.38 ± 0.45
`cairo-native (standalone AOT with -march=native)`	0.214 ± 0.005	0.206	0.224	1.00

Benchmark for program `dict_snapshot`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	5.964 ± 0.077	5.858	6.096	3060.56 ± 87.81
`cairo-native (embedded AOT)`	3.989 ± 0.062	3.905	4.072	2046.72 ± 61.26
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.816 ± 0.037	3.745	3.883	1958.27 ± 53.66
`cairo-native (standalone AOT with -march=native)`	0.002 ± 0.000	0.002	0.003	1.00

Benchmark for program `factorial_2M`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	14.964 ± 0.122	14.812	15.226	11.02 ± 0.10
`cairo-native (embedded AOT)`	4.385 ± 0.043	4.317	4.446	3.23 ± 0.03
`cairo-native (embedded JIT using LLVM's ORC Engine)`	4.171 ± 0.040	4.126	4.234	3.07 ± 0.03
`cairo-native (standalone AOT with -march=native)`	1.358 ± 0.006	1.354	1.372	1.00

Benchmark for program `fib_2M`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	14.654 ± 0.092	14.520	14.785	181.42 ± 1.24
`cairo-native (embedded AOT)`	3.939 ± 0.038	3.871	3.994	48.77 ± 0.49
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.860 ± 0.054	3.768	3.933	47.78 ± 0.68
`cairo-native (standalone AOT with -march=native)`	0.081 ± 0.000	0.080	0.081	1.00

Benchmark for program `linear_search`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	6.004 ± 0.077	5.856	6.123	2938.84 ± 123.04
`cairo-native (embedded AOT)`	4.013 ± 0.062	3.909	4.117	1964.31 ± 84.02
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.886 ± 0.054	3.819	3.955	1902.03 ± 80.33
`cairo-native (standalone AOT with -march=native)`	0.002 ± 0.000	0.002	0.002	1.00

Benchmark for program `logistic_map`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	5.881 ± 0.041	5.825	5.929	24.24 ± 0.17
`cairo-native (embedded AOT)`	4.002 ± 0.024	3.970	4.038	16.49 ± 0.10
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.935 ± 0.030	3.896	3.975	16.22 ± 0.12
`cairo-native (standalone AOT with -march=native)`	0.243 ± 0.000	0.242	0.243	1.00

src/compiler.rs

azteca1998 · 2025-01-16T16:39:40Z

src/executor.rs

@@ -635,9 +635,9 @@ fn parse_result(
        | CoreTypeConcrete::StarkNet(_)
        | CoreTypeConcrete::Uint128MulGuarantee(_)
        | CoreTypeConcrete::Circuit(_)
-        | CoreTypeConcrete::RangeCheck96(_) => todo!(),
+        | CoreTypeConcrete::RangeCheck96(_) => native_panic!("not yet implemented as results"),


The RangeCheck96 is a builtin, therefore should go in the builtins category (the block just above, after RangeCheck).

src/libfuncs/int.rs

src/types/circuit.rs

Co-authored-by: MrAzteca <[email protected]>

codecov-commenter · 2025-01-16T19:01:28Z

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (ecb0c82) to head (67a9f68).

Files with missing lines	Patch %	Lines
src/libfuncs/const.rs	0.00%	9 Missing ⚠️
src/bin/utils/mod.rs	0.00%	3 Missing ⚠️
src/executor.rs	0.00%	2 Missing ⚠️
src/compiler.rs	0.00%	1 Missing ⚠️
src/libfuncs/int.rs	0.00%	1 Missing ⚠️
src/types/circuit.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   80.94%   80.94%   -0.01%     
==========================================
  Files         108      108              
  Lines       29978    29978              
==========================================
- Hits        24266    24265       -1     
- Misses       5712     5713       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: MrAzteca <[email protected]>

github-actions · 2025-01-17T14:13:02Z

✅ Code is now correctly formatted.

Remove missing todos

4639454

edg-l requested review from igaray, azteca1998, jrchatruc, entropidelic, fmoletta, Oppen, pefontana and gabrielbosio as code owners January 16, 2025 15:21

JulianGCalderon previously approved these changes Jan 16, 2025

View reviewed changes

FrancoGiachetta previously approved these changes Jan 16, 2025

View reviewed changes

azteca1998 reviewed Jan 16, 2025

View reviewed changes

Update src/compiler.rs

e5cbf13

Co-authored-by: MrAzteca <[email protected]>

edg-l dismissed stale reviews from FrancoGiachetta and JulianGCalderon via e5cbf13 January 16, 2025 16:49

edg-l and others added 3 commits January 17, 2025 15:12

Update src/types/circuit.rs

b1bc0d1

Co-authored-by: MrAzteca <[email protected]>

Update src/libfuncs/int.rs

1ef0d5f

Co-authored-by: MrAzteca <[email protected]>

Merge branch 'main' into missing_todos

9b83d02

edg-l added 4 commits January 20, 2025 09:58

fmt

b7dfd1c

clippy

0022d14

Merge branch 'main' into missing_todos

f1df319

fix

67a9f68

JulianGCalderon approved these changes Jan 22, 2025

View reviewed changes

edg-l added the review-ready A PR that is ready for review label Jan 23, 2025

FrancoGiachetta approved these changes Jan 23, 2025

View reviewed changes

edg-l enabled auto-merge January 23, 2025 14:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove missing todos #1055

Remove missing todos #1055

edg-l commented Jan 16, 2025

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

azteca1998 Jan 16, 2025

codecov-commenter commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading

Remove missing todos #1055

Are you sure you want to change the base?

Remove missing todos #1055

Conversation

edg-l commented Jan 16, 2025

Checklist

github-actions bot commented Jan 16, 2025 • edited Loading

Benchmark results Main vs HEAD.

Base

Head

Base

Head

Base

Head

Base

Head

Base

Head

Base

Head

github-actions bot commented Jan 16, 2025 • edited Loading

Benchmarking results

Benchmark for program dict_insert

Benchmark for program dict_snapshot

Benchmark for program factorial_2M

Benchmark for program fib_2M

Benchmark for program linear_search

Benchmark for program logistic_map

azteca1998 Jan 16, 2025

Choose a reason for hiding this comment

codecov-commenter commented Jan 16, 2025 • edited Loading

Codecov Report

github-actions bot commented Jan 17, 2025 • edited Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

Benchmark for program `dict_insert`

Benchmark for program `dict_snapshot`

Benchmark for program `factorial_2M`

Benchmark for program `fib_2M`

Benchmark for program `linear_search`

Benchmark for program `logistic_map`

codecov-commenter commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025 •

edited

Loading