Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cairo-lang to 2.10.0-rc0 #1056

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Pin cairo-lang to 2.10.0-rc0 #1056

merged 1 commit into from
Jan 16, 2025

Conversation

gabrielbosio
Copy link
Collaborator

Avoids updating cairo-lang to 2.10.0-rc1. We need to adapt Native to that new version first.

@gabrielbosio gabrielbosio force-pushed the pin_cairo_lang_2.10.0-rc0 branch from 5c6796d to 4c8e450 Compare January 16, 2025 19:09
Copy link

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.803 ± 0.020 3.774 3.836 1.00
base dict_insert.cairo (AOT) 3.966 ± 0.020 3.944 4.000 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.966 ± 0.051 3.849 4.044 1.00
head dict_insert.cairo (AOT) 4.282 ± 0.057 4.205 4.387 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 3.681 ± 0.026 3.647 3.742 1.00
base dict_snapshot.cairo (AOT) 3.854 ± 0.044 3.812 3.939 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 4.066 ± 0.079 3.914 4.163 1.00 ± 0.02
head dict_snapshot.cairo (AOT) 4.065 ± 0.053 4.006 4.138 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.106 ± 0.032 4.073 4.171 1.00
base factorial_2M.cairo (AOT) 4.303 ± 0.027 4.241 4.340 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.215 ± 0.022 4.170 4.251 1.00
head factorial_2M.cairo (AOT) 4.422 ± 0.027 4.365 4.470 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.609 ± 0.034 3.570 3.685 1.00
base fib_2M.cairo (AOT) 3.783 ± 0.014 3.755 3.806 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.740 ± 0.035 3.699 3.804 1.00
head fib_2M.cairo (AOT) 3.988 ± 0.020 3.955 4.025 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.792 ± 0.032 3.731 3.841 1.00
base linear_search.cairo (AOT) 3.941 ± 0.035 3.891 4.013 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.920 ± 0.041 3.849 3.984 1.00
head linear_search.cairo (AOT) 4.106 ± 0.043 4.027 4.168 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.888 ± 0.028 3.839 3.923 1.00
base logistic_map.cairo (AOT) 3.949 ± 0.026 3.915 4.004 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 4.110 ± 0.050 4.045 4.203 1.00
head logistic_map.cairo (AOT) 4.143 ± 0.053 4.060 4.243 1.01 ± 0.02

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.95%. Comparing base (1191808) to head (4c8e450).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         108      108           
  Lines       29938    29938           
=======================================
  Hits        24237    24237           
  Misses       5701     5701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 21.067 ± 0.105 20.916 21.269 94.20 ± 2.74
cairo-native (embedded AOT) 4.149 ± 0.035 4.094 4.189 18.55 ± 0.55
cairo-native (embedded JIT using LLVM's ORC Engine) 4.018 ± 0.049 3.947 4.091 17.97 ± 0.56
cairo-native (standalone AOT with -march=native) 0.224 ± 0.006 0.212 0.235 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.947 ± 0.066 5.863 6.100 3026.35 ± 89.27
cairo-native (embedded AOT) 4.116 ± 0.058 4.038 4.213 2094.73 ± 64.34
cairo-native (embedded JIT using LLVM's ORC Engine) 3.890 ± 0.029 3.857 3.940 1979.42 ± 56.07
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.931 ± 0.075 14.847 15.093 11.01 ± 0.06
cairo-native (embedded AOT) 4.401 ± 0.034 4.335 4.449 3.25 ± 0.03
cairo-native (embedded JIT using LLVM's ORC Engine) 4.152 ± 0.034 4.108 4.204 3.06 ± 0.03
cairo-native (standalone AOT with -march=native) 1.356 ± 0.002 1.354 1.359 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.813 ± 0.088 14.629 14.904 183.42 ± 1.42
cairo-native (embedded AOT) 3.994 ± 0.028 3.953 4.061 49.45 ± 0.42
cairo-native (embedded JIT using LLVM's ORC Engine) 3.753 ± 0.031 3.715 3.807 46.48 ± 0.44
cairo-native (standalone AOT with -march=native) 0.081 ± 0.000 0.080 0.082 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.941 ± 0.105 5.777 6.091 2997.56 ± 84.00
cairo-native (embedded AOT) 4.036 ± 0.030 3.988 4.077 2036.66 ± 46.74
cairo-native (embedded JIT using LLVM's ORC Engine) 3.905 ± 0.027 3.871 3.953 1970.54 ± 44.96
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.002 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.839 ± 0.043 5.773 5.900 24.08 ± 0.18
cairo-native (embedded AOT) 4.026 ± 0.026 3.992 4.078 16.60 ± 0.11
cairo-native (embedded JIT using LLVM's ORC Engine) 3.998 ± 0.046 3.912 4.069 16.48 ± 0.19
cairo-native (standalone AOT with -march=native) 0.243 ± 0.000 0.242 0.244 1.00

@gabrielbosio gabrielbosio added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 965e3f9 Jan 16, 2025
28 checks passed
@gabrielbosio gabrielbosio deleted the pin_cairo_lang_2.10.0-rc0 branch January 16, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants