Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cairo to 2.10.0-rc1 #1059

Merged
merged 10 commits into from
Jan 20, 2025
Merged

Update cairo to 2.10.0-rc1 #1059

merged 10 commits into from
Jan 20, 2025

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 17, 2025

The corelib includes test for these:

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Copy link

github-actions bot commented Jan 17, 2025

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.870 ± 0.026 3.833 3.915 1.00
base dict_insert.cairo (AOT) 4.054 ± 0.027 4.014 4.095 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_insert.cairo (JIT) 3.992 ± 0.067 3.913 4.137 1.00
head dict_insert.cairo (AOT) 4.229 ± 0.047 4.149 4.302 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 3.758 ± 0.019 3.736 3.789 1.00
base dict_snapshot.cairo (AOT) 3.915 ± 0.027 3.866 3.959 1.04 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head dict_snapshot.cairo (JIT) 3.906 ± 0.035 3.835 3.962 1.00
head dict_snapshot.cairo (AOT) 4.094 ± 0.060 4.037 4.227 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.090 ± 0.010 4.079 4.106 1.00
base factorial_2M.cairo (AOT) 4.316 ± 0.024 4.276 4.348 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 4.257 ± 0.038 4.196 4.326 1.00
head factorial_2M.cairo (AOT) 4.488 ± 0.044 4.434 4.575 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.677 ± 0.047 3.601 3.744 1.00
base fib_2M.cairo (AOT) 3.886 ± 0.037 3.846 3.953 1.06 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 3.734 ± 0.031 3.687 3.772 1.00
head fib_2M.cairo (AOT) 3.945 ± 0.027 3.908 3.986 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.823 ± 0.021 3.789 3.853 1.00
base linear_search.cairo (AOT) 3.953 ± 0.021 3.916 3.985 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head linear_search.cairo (JIT) 3.918 ± 0.045 3.858 4.009 1.00
head linear_search.cairo (AOT) 4.049 ± 0.027 4.024 4.113 1.03 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.923 ± 0.022 3.892 3.954 1.00
base logistic_map.cairo (AOT) 4.012 ± 0.019 3.987 4.041 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 4.057 ± 0.039 3.995 4.117 1.00
head logistic_map.cairo (AOT) 4.119 ± 0.033 4.072 4.199 1.02 ± 0.01

Copy link

github-actions bot commented Jan 17, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.784 ± 0.124 20.675 21.105 98.27 ± 3.94
cairo-native (embedded AOT) 4.010 ± 0.028 3.976 4.076 18.96 ± 0.76
cairo-native (embedded JIT using LLVM's ORC Engine) 3.864 ± 0.018 3.837 3.893 18.27 ± 0.73
cairo-native (standalone AOT with -march=native) 0.211 ± 0.008 0.195 0.226 1.00

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.850 ± 0.029 5.780 5.883 3065.20 ± 82.06
cairo-native (embedded AOT) 3.851 ± 0.019 3.815 3.869 2017.85 ± 54.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.726 ± 0.020 3.695 3.755 1952.31 ± 52.47
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.003 1.00

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.321 ± 0.049 14.258 14.398 10.56 ± 0.04
cairo-native (embedded AOT) 4.296 ± 0.020 4.274 4.331 3.17 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 4.069 ± 0.025 4.030 4.110 3.00 ± 0.02
cairo-native (standalone AOT with -march=native) 1.356 ± 0.001 1.355 1.357 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.251 ± 0.037 14.207 14.327 176.22 ± 2.12
cairo-native (embedded AOT) 3.830 ± 0.017 3.804 3.860 47.36 ± 0.60
cairo-native (embedded JIT using LLVM's ORC Engine) 3.644 ± 0.034 3.589 3.694 45.06 ± 0.68
cairo-native (standalone AOT with -march=native) 0.081 ± 0.001 0.080 0.086 1.00

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.836 ± 0.021 5.791 5.859 2842.94 ± 76.57
cairo-native (embedded AOT) 3.920 ± 0.023 3.891 3.977 1909.80 ± 52.21
cairo-native (embedded JIT using LLVM's ORC Engine) 3.805 ± 0.035 3.771 3.892 1853.79 ± 52.39
cairo-native (standalone AOT with -march=native) 0.002 ± 0.000 0.002 0.003 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.737 ± 0.027 5.686 5.767 23.50 ± 0.22
cairo-native (embedded AOT) 3.969 ± 0.042 3.931 4.072 16.26 ± 0.22
cairo-native (embedded JIT using LLVM's ORC Engine) 3.977 ± 0.076 3.882 4.098 16.29 ± 0.34
cairo-native (standalone AOT with -march=native) 0.244 ± 0.002 0.243 0.250 1.00

@edg-l edg-l marked this pull request as ready for review January 17, 2025 14:16
@edg-l edg-l dismissed stale reviews from JulianGCalderon and FrancoGiachetta via d4ddf90 January 20, 2025 14:11
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (0befa7c) to head (d4ddf90).

Files with missing lines Patch % Lines
src/libfuncs/const.rs 0.00% 10 Missing ⚠️
src/debug.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   80.95%   80.92%   -0.03%     
==========================================
  Files         108      108              
  Lines       29938    29949      +11     
==========================================
  Hits        24237    24237              
- Misses       5701     5712      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gabrielbosio gabrielbosio added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit e9151aa Jan 20, 2025
28 checks passed
@gabrielbosio gabrielbosio deleted the update_cairo_rc1 branch January 20, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants