Fix sierra emu eval_trim and add int range to trace dump #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrancoGiachetta
requested review from
Oppen,
azteca1998,
edg-l,
entropidelic,
fmoletta,
gabrielbosio,
igaray,
jrchatruc and
pefontana
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 105 105
Lines 25759 25759
=======================================
Hits 20987 20987
Misses 4772 4772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.788 ± 0.019 | 10.763 | 10.814 | 6.33 ± 0.05 |
cairo-native (embedded AOT) |
1.705 ± 0.012 | 1.683 | 1.721 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.768 ± 0.008 | 1.753 | 1.780 | 1.04 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
506.2 ± 5.4 | 500.6 | 519.0 | 1.00 |
cairo-native (embedded AOT) |
1400.5 ± 11.2 | 1384.1 | 1420.7 | 2.77 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1496.0 ± 11.6 | 1478.4 | 1511.0 | 2.96 ± 0.04 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.793 ± 0.005 | 4.786 | 4.801 | 2.71 ± 0.02 |
cairo-native (embedded AOT) |
1.770 ± 0.010 | 1.756 | 1.782 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.814 ± 0.012 | 1.798 | 1.836 | 1.02 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.705 ± 0.019 | 4.690 | 4.754 | 3.41 ± 0.04 |
cairo-native (embedded AOT) |
1.380 ± 0.015 | 1.361 | 1.412 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.416 ± 0.019 | 1.398 | 1.462 | 1.03 ± 0.02 |
Benchmark for program heavy_circuit
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.383 ± 0.113 | 10.213 | 10.589 | 1.17 ± 0.02 |
cairo-native (embedded AOT) |
8.877 ± 0.072 | 8.777 | 8.987 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
9.267 ± 0.065 | 9.198 | 9.420 | 1.04 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
537.6 ± 5.1 | 530.9 | 548.1 | 1.00 |
cairo-native (embedded AOT) |
1448.5 ± 16.8 | 1425.7 | 1489.6 | 2.69 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1560.5 ± 14.1 | 1538.7 | 1588.5 | 2.90 ± 0.04 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
461.4 ± 2.8 | 456.0 | 466.1 | 1.00 |
cairo-native (embedded AOT) |
1551.8 ± 16.6 | 1533.1 | 1588.3 | 3.36 ± 0.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1732.5 ± 8.3 | 1715.6 | 1741.9 | 3.76 ± 0.03 |
gabrielbosio
approved these changes
Nov 14, 2025
DiegoCivi
reviewed
Nov 28, 2025
| CoreTypeConcrete::IntRange(info) => { | ||
| let type_info = registry.get_type(&info.ty).unwrap(); | ||
|
|
||
| match type_info { |
Contributor
There was a problem hiding this comment.
Don´t we need in this match to handle the case of a BoundedInt?
Contributor
Author
There was a problem hiding this comment.
It was not the aim of this PR honestly, and it seems not to be necessary for now.
Contributor
There was a problem hiding this comment.
We could at least add a todo for it, so that we remember to implement it later.
DiegoCivi
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sierra emu eval_trim and add int range to trace dump
Closes #NA
This PR fixes
bounded_int_trimlibfuncs in sierra-emu. The issue was that the implementation was not taking into account that it could receiveBoundedInts as inputs.This PR also implements dumping
IntRanges with the trace dump.Introduces Breaking Changes?
No.
starknet-blocks.ymlworkflow to use these PRs.These PRs should be merged after this one right away, in that order.
Checklist