-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase test coverage of metadata DebugUtils
#616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 88.76% 90.42% +1.66%
==========================================
Files 121 121
Lines 35627 36263 +636
==========================================
+ Hits 31624 32791 +1167
+ Misses 4003 3472 -531 ☔ View full report in Codecov by Sentry. |
Two things:
What I would expect from these tests is this:
|
e4c8d7f
to
d8159fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This module is for debugging, and it's not intended to even be compiled in normal builds so there's no need to test it more than we already do every time we need to use it. That said, any extra testing is appreciated.
The debug utils module is only used when debugging bugs internally in cairo native, as @azteca1998 pointed out I also don't think the tests are necesary for now |
Checklist