-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks comparing to Cairo VM #692
Merged
Merged
Changes from 12 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
a1237aa
Add benches
JulianGCalderon 2ad28d0
Merge branch 'main' into benches_vs_vm
JulianGCalderon 1ef0826
Fix clippy
JulianGCalderon 243d629
Merge branch 'main' into benches_vs_vm
edg-l 702fd8a
Merge branch 'main' into benches_vs_vm
JulianGCalderon 642e6ff
Add more cases
JulianGCalderon ca6629b
Use fibonacci instead of fib
JulianGCalderon 6ff72dd
Differenciate expect messages
JulianGCalderon 8c726fb
Separate into groups per program
JulianGCalderon 094c7b4
Merge branch 'main' into benches_vs_vm
JulianGCalderon b88d39b
Merge branch 'main' into benches_vs_vm
pefontana ae204ba
Merge branch 'main' into benches_vs_vm
pefontana 332ca73
Merge branch 'main' into benches_vs_vm
edg-l 3baaa79
Merge branch 'main' into benches_vs_vm
JulianGCalderon 897838c
Merge branch 'main' into benches_vs_vm
JulianGCalderon 4d379fe
Add result checks
JulianGCalderon 5083718
Merge branch 'benches_vs_vm_2' into benches_vs_vm
JulianGCalderon 6bd8a12
Fix clippy
JulianGCalderon f21ffda
Merge branch 'main' into benches_vs_vm
JulianGCalderon dbb6fc7
Add compile bench
JulianGCalderon ce8e90a
Add linear search
JulianGCalderon 8b30ed3
Add linear search bench
JulianGCalderon eab4bd6
Lower time
JulianGCalderon 7bf2647
Fix program
JulianGCalderon 1ebd0df
Add linear_search.c
JulianGCalderon 16cfb8e
Merge branch 'main' into benches_vs_vm
JulianGCalderon 356b47a
Add builtin
JulianGCalderon 7ba0be1
Fix
JulianGCalderon 019f74e
Fix symbol number
JulianGCalderon 0680850
Merge branch 'main' into benches_vs_vm
JulianGCalderon 8ab047c
Merge branch 'main' into benches_vs_vm
JulianGCalderon 2a08449
Update benches
JulianGCalderon 5ee1ea5
Merge branch 'main' into benches_vs_vm
JulianGCalderon a380aa2
Fix bench
JulianGCalderon 2f35f5d
Merge branch 'main' into benches_vs_vm
JulianGCalderon 88d9006
Remove comp benchmark
JulianGCalderon d66321f
Remove extra dependency
JulianGCalderon 9f05acf
Merge branch 'main' into benches_vs_vm
JulianGCalderon abdfcbd
Merge branch 'main' into benches_vs_vm
JulianGCalderon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to find another way to execute the VM.
See the
fn run_function_with_starknet_context
It clone the casm_program adding lot of overhead to the execution
We need to discuss how we do this, maybe we have to add a new method to the
cairo-vm/cairo1-run
crateThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that particular issue has been fixed: https://github.com/starkware-libs/cairo/blob/226c3646be247828c08b737a73f6da10de76e0fc/crates/cairo-lang-runner/src/lib.rs#L191