Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scarb in makefile #818

Merged
merged 1 commit into from
Sep 27, 2024
Merged

update scarb in makefile #818

merged 1 commit into from
Sep 27, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Sep 27, 2024

https://github.com/software-mansion/scarb/releases/tag/v2.8.3

it uses cairo 2.8.2 still

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@edg-l edg-l added the review-ready A PR that is ready for review label Sep 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (e98613c) to head (d936e6d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         122      122           
  Lines       34169    34169           
=======================================
  Hits        30087    30087           
  Misses       4082     4082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 27, 2024

Benchmark results Main vs HEAD

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.126 ± 0.069 3.068 3.286 1.01 ± 0.02
base factorial_2M.cairo (JIT) 3.140 ± 0.021 3.086 3.162 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.106 ± 0.023 3.059 3.134 1.00
base factorial_2M.cairo (AOT) 3.108 ± 0.017 3.089 3.145 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.643 ± 0.018 2.612 2.675 1.00
base fib_2M.cairo (JIT) 2.648 ± 0.010 2.635 2.669 1.00 ± 0.01
head fib_2M.cairo (AOT) 2.664 ± 0.015 2.634 2.681 1.01 ± 0.01
base fib_2M.cairo (AOT) 2.670 ± 0.016 2.655 2.701 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.072 ± 0.018 3.046 3.114 1.06 ± 0.01
base logistic_map.cairo (JIT) 3.085 ± 0.022 3.044 3.120 1.06 ± 0.01
head logistic_map.cairo (AOT) 2.912 ± 0.034 2.863 2.962 1.00 ± 0.01
base logistic_map.cairo (AOT) 2.902 ± 0.014 2.880 2.929 1.00

@pefontana pefontana added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 40dd1b6 Sep 27, 2024
15 checks passed
@pefontana pefontana deleted the upd_scarb branch September 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants