Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace dump contracts 2 #838

Merged
merged 50 commits into from
Oct 21, 2024
Merged

Conversation

JulianGCalderon
Copy link
Contributor

Implements more types

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

JulianGCalderon and others added 23 commits October 4, 2024 11:08
* add is_infinity to secp point

* clean

* fix

* use same deps as blockifier

* fix

* fix layout

* fix test

* remove some brittle asserts due to random initial data when adding and muling points at infinity

* fix

* remove unused dep

* fixes, missed the value entry/output
* fix storage's values truncations

* change implementation for i8 i16 i32 i64 too

* format
* Add memory tracing.

* Partial memory fixes.

* Fix arrays.

* Simplify dictionaries. Fix false positive memory leak in dictionary drops.

* Fix zero-sized allocation. Fix warnings. More mem tracing checks.

* Fix mem tracing.

* Fix memory leak in `print` libfunc.

* Fix array slice libfunc.

* Fix starknet memory leaks.

* Fix keccak syscall.

* Fix dict get double free bug.

* Lots of memory fixes.

* More fixes.

* Fix CI.

* Remove old TODOs.

* Fix CI (again).

* Remove TODOs.

* Fix test.
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 79.51743% with 382 lines in your changes missing coverage. Please review.

Project coverage is 82.74%. Comparing base (cff7a11) to head (07bf052).
Report is 12 commits behind head on add-trace-dump-contracts.

Files with missing lines Patch % Lines
src/starknet.rs 16.23% 98 Missing ⚠️
src/types/starknet.rs 1.96% 50 Missing ⚠️
src/starknet_stub.rs 73.48% 48 Missing ⚠️
src/libfuncs/starknet.rs 0.00% 46 Missing ⚠️
src/libfuncs/array.rs 86.21% 43 Missing ⚠️
src/executor/contract.rs 70.83% 14 Missing ⚠️
src/ffi.rs 33.33% 14 Missing ⚠️
src/libfuncs/gas.rs 85.10% 14 Missing ⚠️
src/compiler.rs 89.89% 10 Missing ⚠️
src/metadata/runtime_bindings.rs 94.18% 10 Missing ⚠️
... and 16 more

❗ There is a different number of reports uploaded between BASE (cff7a11) and HEAD (07bf052). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cff7a11) HEAD (07bf052)
2 1
Additional details and impacted files
@@                     Coverage Diff                      @@
##           add-trace-dump-contracts     #838      +/-   ##
============================================================
- Coverage                     88.11%   82.74%   -5.38%     
============================================================
  Files                           123      120       -3     
  Lines                         34973    34954      -19     
============================================================
- Hits                          30818    28922    -1896     
- Misses                         4155     6032    +1877     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JulianGCalderon and others added 6 commits October 10, 2024 12:03
* Update to 2.8.4, release docs, alpha

This PR updates cairo to 2.8.4, adds some release docs and updates the
version to alpha.3 to prepare for another release.

* try fix

* cleanup ci, remove panic in link

* rename from jit to from ptr, etc

* crates.io badge

* progress

* progress

* fmt2

* progress

* progress

* fix

* fix bench

* use struct
JulianGCalderon and others added 19 commits October 14, 2024 10:54
* Fix felt252 and enum deserialization bugs.

* Fix formatting.

* Also fix the runtime.

* Fix errors.

* try to fix ci

* remove unused deps

* fix aot contract executor not passing builtinstats

---------

Co-authored-by: Esteve Soler Arderiu <[email protected]>
Co-authored-by: Esteve Soler Arderiu <[email protected]>
* Also fix felt bits in starknet syscall wrappers

* style

* missed
* Fix felt252 and enum deserialization bugs.

* Fix formatting.

* Also fix the runtime.

* Fix errors.

* try to fix ci

* remove unused deps

* fix aot contract executor not passing builtinstats

---------

Co-authored-by: Esteve Soler Arderiu <[email protected]>
Co-authored-by: Esteve Soler Arderiu <[email protected]>
* Also fix felt bits in starknet syscall wrappers

* style

* missed
* Fix felt252 and enum deserialization bugs.

* Fix formatting.

* Also fix the runtime.

* Fix errors.

* try to fix ci

* remove unused deps

* proper function attributes

* add proper function attrs to optimize better, add some passes, run tests with atleast some opts

* dont use remi

* oops

* maybe with opt level 3 now it works

* test

* works

* readd deleted bench

* remove dbg

* Update bench-hyperfine.sh

* fixci

* comment

* Update src/ffi.rs

Co-authored-by: MrAzteca <[email protected]>

---------

Co-authored-by: Esteve Soler Arderiu <[email protected]>
Co-authored-by: Esteve Soler Arderiu <[email protected]>
Co-authored-by: MrAzteca <[email protected]>
* feat(ffi): resolve runtime relative path using current dir

* chore: remove mentions to old runtime variable

* fix: typo

---------

Co-authored-by: Bohdan Ohorodnii <[email protected]>
@JulianGCalderon JulianGCalderon marked this pull request as ready for review October 18, 2024 15:07
@edg-l edg-l merged commit c989b31 into add-trace-dump-contracts Oct 21, 2024
11 checks passed
@edg-l edg-l deleted the add-trace-dump-contracts-2 branch October 21, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants