-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks Running Workflow #869
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #869 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 120 120
Lines 34941 34941
=======================================
Hits 28941 28941
Misses 6000 6000 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.065 ± 0.291 | 10.806 | 11.600 | 24.68 ± 0.65 |
cairo-native (embedded AOT) |
3.330 ± 0.032 | 3.274 | 3.377 | 7.43 ± 0.07 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.374 ± 0.019 | 3.343 | 3.403 | 7.52 ± 0.04 |
cairo-native (standalone AOT) |
0.673 ± 0.001 | 0.672 | 0.675 | 1.50 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.448 ± 0.000 | 0.448 | 0.449 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.135 ± 0.290 | 10.831 | 11.505 | 1378.50 ± 41.33 |
cairo-native (embedded AOT) |
2.866 ± 0.030 | 2.832 | 2.915 | 354.83 ± 6.43 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.884 ± 0.027 | 2.840 | 2.927 | 357.05 ± 6.30 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.04 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.010 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.451 ± 0.035 | 4.397 | 4.506 | 62.67 ± 0.59 |
cairo-native (embedded AOT) |
3.000 ± 0.042 | 2.954 | 3.093 | 42.25 ± 0.63 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.170 ± 0.029 | 3.120 | 3.214 | 44.64 ± 0.47 |
cairo-native (standalone AOT) |
0.115 ± 0.000 | 0.114 | 0.115 | 1.61 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.071 ± 0.000 | 0.071 | 0.073 | 1.00 |
Benchmark results Main vs HEAD.
|
…s/cairo_native into workflow-small-execute-blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amaizing work @FrancoGiachetta !!!
Changes done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works, but it's difficult to say as it can only be tested in the CI. Just to make sure, could you test it with some failing blocks? That way we can ensure that the workflow detects blocks with diffs.
Yes, makes sense. I will replace some of them with the ones that seem to be failing recently |
It seems to be working OK. Should we tag the workflow as |
Sure! I will add them |
This PR adds a workflow which executes a small range of blocks both the vm and native, dumps the final state that the execution throws and compares with each other. If there's any diff, it will fail.
Closes #852
Checklist