Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo 2.9.0-dev (native v0.2.3 branch) #877

Merged
merged 36 commits into from
Nov 20, 2024
Merged

cairo 2.9.0-dev (native v0.2.3 branch) #877

merged 36 commits into from
Nov 20, 2024

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Oct 23, 2024

Fixes #879

This is cairo-native with cairo 2.9.0 features

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

* implement get_class_hash_at syscall

* fix
Copy link

github-actions bot commented Oct 24, 2024

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.309 ± 0.305 10.905 11.883 8.39 ± 0.23
cairo-native (embedded AOT) 3.564 ± 0.032 3.525 3.616 2.65 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 3.314 ± 0.060 3.210 3.410 2.46 ± 0.04
cairo-native (standalone AOT with -march=native) 1.347 ± 0.002 1.345 1.351 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.311 ± 0.277 10.986 11.698 144.75 ± 3.61
cairo-native (embedded AOT) 3.081 ± 0.040 3.040 3.161 39.42 ± 0.54
cairo-native (embedded JIT using LLVM's ORC Engine) 2.860 ± 0.048 2.795 2.934 36.60 ± 0.64
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.078 0.080 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.184 ± 0.037 4.141 4.257 17.24 ± 0.21
cairo-native (embedded AOT) 3.055 ± 0.054 3.016 3.176 12.59 ± 0.25
cairo-native (embedded JIT using LLVM's ORC Engine) 2.993 ± 0.035 2.950 3.067 12.33 ± 0.18
cairo-native (standalone AOT with -march=native) 0.243 ± 0.002 0.242 0.249 1.00

@edg-l edg-l marked this pull request as ready for review October 24, 2024 14:19
@edg-l edg-l changed the title update to cairo 2.9.0-dev cairo 2.9.0-dev (native v0.2.2-alpha.0 branch) Nov 14, 2024
@edg-l edg-l changed the title cairo 2.9.0-dev (native v0.2.2-alpha.0 branch) cairo 2.9.0-dev (native v0.2.3 branch) Nov 19, 2024
@edg-l edg-l added the review-ready A PR that is ready for review label Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 3.271 ± 0.040 3.234 3.343 1.00
base factorial_2M.cairo (AOT) 3.449 ± 0.038 3.391 3.503 1.05 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head factorial_2M.cairo (JIT) 3.208 ± 0.022 3.180 3.257 1.00
head factorial_2M.cairo (AOT) 3.397 ± 0.030 3.373 3.450 1.06 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 2.796 ± 0.024 2.756 2.837 1.00
base fib_2M.cairo (AOT) 3.009 ± 0.035 2.945 3.061 1.08 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head fib_2M.cairo (JIT) 2.764 ± 0.024 2.737 2.816 1.00
head fib_2M.cairo (AOT) 2.958 ± 0.026 2.925 3.003 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.071 ± 0.025 3.018 3.104 1.00
base logistic_map.cairo (AOT) 3.134 ± 0.022 3.103 3.170 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
:--- ---: ---: ---: ---:
head logistic_map.cairo (JIT) 3.055 ± 0.019 3.024 3.094 1.00
head logistic_map.cairo (AOT) 3.161 ± 0.045 3.108 3.262 1.03 ± 0.02

examples/erc20.rs Outdated Show resolved Hide resolved
examples/starknet.rs Outdated Show resolved Hide resolved
src/values.rs Show resolved Hide resolved
src/values.rs Outdated Show resolved Hide resolved
src/values.rs Outdated Show resolved Hide resolved
edg-l and others added 2 commits November 20, 2024 14:55
src/values.rs Outdated Show resolved Hide resolved
@azteca1998 azteca1998 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 5e60089 Nov 20, 2024
32 checks passed
@azteca1998 azteca1998 deleted the update_2_9 branch November 20, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready A PR that is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.9.0] Implement int_range_try_new and int_range_pop_front libfuncs
6 participants