Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeName to AST #154

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add TypeName to AST #154

merged 2 commits into from
Jan 13, 2025

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Jan 10, 2025

Depends on #153

Allows type names to have a full path and generics and more flexiblity.

let x: std::module::Type<T> = ..;

Previously types couldnt have a path (the :: part )

Copy link

Benchmarking factorial

Compiling factorial (factorial.con)
Finished release in 30.149029ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 59.42 ms
Rust Result = 2432902008176640000 Time taken : 60.39 ms

Benchmarking fib

Compiling fib (fib.con)
Finished release in 26.088196ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.56 ms
Rust Result = 6765 Time taken : 85.81 ms

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (f245097) to head (a2ad74d).

Files with missing lines Patch % Lines
src/ir/lowering.rs 20.00% 8 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           impl_grammar     #154      +/-   ##
================================================
- Coverage         62.66%   62.54%   -0.12%     
================================================
  Files                20       20              
  Lines              4676     4680       +4     
================================================
- Hits               2930     2927       -3     
- Misses             1746     1753       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l merged commit 793e5b7 into impl_grammar Jan 13, 2025
7 checks passed
@edg-l edg-l deleted the add_type_names branch January 13, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants