Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(levm): run eof tests #1588

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Dec 30, 2024

Motivation

The goal is to try a simple adaptation to EOF hardfork.

Description

The idea is to make the tests from crates/vm/levm/tests/eof_tests.rs pass with a simple implementation.

The status is the following:

  • I implemented a simple parsing of containers, and there is an rjump implementation, but it has a bug for parsing negative numbers.
  • The tests failing are from the EOF functionalities not implemented (and the only test that should pass is the first).
  • I choosed to implement the Structured bytecode with an enum to support previous versions, but in a future I would use the Spec Id already used to make pass the previous versions.
  • The main source to this implementation is the eof docs
  • There are some clippy alerts failing, but I preferred to keep some of them to make the code more understandable at first glance.
  • There are some more unit test cases in c++ in evmone repo's test folder.

@maximopalopoli maximopalopoli added the levm Lambda EVM implementation label Dec 30, 2024
@maximopalopoli maximopalopoli self-assigned this Dec 30, 2024
@maximopalopoli maximopalopoli changed the title levm(feat): Run eof tests levm(feat): run eof tests Dec 30, 2024
@maximopalopoli maximopalopoli changed the title levm(feat): run eof tests feat(levm): run eof tests Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
levm Lambda EVM implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant