-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l1, levm): use levm as default #1682
base: main
Are you sure you want to change the base?
Conversation
Total lines added: 0 |
Benchmark Results ComparisonPR ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
Main ResultsBenchmark Results: Factorial
Benchmark Results: Fibonacci
|
|
docker build -t ethrex --build-arg "BUILD_FLAGS=${--features levm}" . | ||
touch $(STAMP_FILE) | ||
|
||
STAMP_FILE_REVM := .docker_build_stamp_revm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we wait for #1706 so that we don't have to create this extra code? After 1706 this PR should be trivial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can. I'll reduce #1706 scope to just replacing the use of feature flags with the ethrex
CLI flag so it can be delivered sooner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for #1706
Description
Make levm the default vm used with ethrex.
Closes #1628.