chore(l2): bump up sp1 version #1734
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fborello-lambda
changed the title
|
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
**Motivation** The CI is failing because we are downloading the latest version of sp1 (`4.0.0`), bumping up the version implies some changes and further testing. **Description** Momentary solution: - download past version. Linked to #1734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Didn't test it out thoroughly, just used the
perf-sp1target fromcrates/l2/prover. This change may break some things.Note
To use it locally, the latest version has to be installed. The following command can be used.
sp1up --version 4.0.0Useful docs → sp1-v4-migration-guide
Motivation
SP1 version was updated, we should bump it up to the latest
Description
Use version 4.0.0 and update the other dependencies.
A test is failing:
ethrex/crates/l2/utils/prover/save_state.rs
Line 388 in 990fa2b
The test saves proofs on disk to keep track of them, but it panics due to an SP1's internal unwrap