Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l1): implement EIP-7002 and EIP-7251 #1950

Merged
merged 23 commits into from
Feb 19, 2025
Merged

feat(l1): implement EIP-7002 and EIP-7251 #1950

merged 23 commits into from
Feb 19, 2025

Conversation

JulianVentura
Copy link
Contributor

@JulianVentura JulianVentura commented Feb 13, 2025

Description

Implements EIP-7002 and EIP-7251, enabling new execution layer requests.

Feature branch was used in order to pass L2 tests, see related issue #1917

Closes #1788, #1790

Copy link

github-actions bot commented Feb 13, 2025

| File                                                               | Lines | Diff |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/cmd/ef_tests/blockchain/network.rs | 80    | +1   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/blockchain.rs    | 212   | +4   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/blockchain/payload.rs       | 691   | +23  |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/constants.rs         | 6     | +4   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/block.rs       | 696   | -4   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/genesis.rs     | 624   | +1   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/common/types/requests.rs    | 104   | +11  |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/networking/rpc/rpc.rs       | 518   | +5   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/backends/constants.rs    | 6     | +3   |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/backends/levm.rs         | 395   | +92  |
+--------------------------------------------------------------------+-------+------+
| /home/runner/work/ethrex/ethrex/crates/vm/backends/revm.rs         | 504   | +47  |
+--------------------------------------------------------------------+-------+------+

Total lines added: +191
Total lines removed: 4
Total lines changed: 195

Base automatically changed from feat/eips-7685-6110 to main February 14, 2025 19:01
@JulianVentura JulianVentura changed the title feat(l1): implement EIP-7002 feat(l1): implement EIP-7002 and EIP-7251 Feb 14, 2025
@JulianVentura JulianVentura marked this pull request as ready for review February 18, 2025 15:34
@JulianVentura JulianVentura requested a review from a team as a code owner February 18, 2025 15:34
@@ -118,13 +127,25 @@ pub fn execute_block(
}
}

cfg_if::cfg_if! {
if #[cfg(not(feature = "l2"))] {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why use of not in if, considering you have an else?

Copy link
Contributor

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some nit comments

@JulianVentura JulianVentura added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit c6ad823 Feb 19, 2025
23 checks passed
@JulianVentura JulianVentura deleted the feat/eip-7002 branch February 19, 2025 19:27
JereSalo pushed a commit that referenced this pull request Feb 28, 2025
**Description**

Implements [EIP-7002](https://eips.ethereum.org/EIPS/eip-7002) and
[EIP-7251](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7251.md),
enabling new execution layer requests.

Feature branch was used in order to pass L2 tests, see related issue
#1917

Closes #1788, #1790

---------

Co-authored-by: Julian Ventura <[email protected]>
Co-authored-by: avilagaston9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EIP-7002: Execution layer triggerable withdrawals
3 participants