-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l1): implement EIP-7002 and EIP-7251 #1950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
24d07f3
to
3588933
Compare
mpaulucci
reviewed
Feb 18, 2025
crates/vm/backends/levm.rs
Outdated
@@ -118,13 +127,25 @@ pub fn execute_block( | |||
} | |||
} | |||
|
|||
cfg_if::cfg_if! { | |||
if #[cfg(not(feature = "l2"))] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: why use of not
in if, considering you have an else
?
avilagaston9
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some nit comments
mpaulucci
approved these changes
Feb 19, 2025
JereSalo
pushed a commit
that referenced
this pull request
Feb 28, 2025
**Description** Implements [EIP-7002](https://eips.ethereum.org/EIPS/eip-7002) and [EIP-7251](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7251.md), enabling new execution layer requests. Feature branch was used in order to pass L2 tests, see related issue #1917 Closes #1788, #1790 --------- Co-authored-by: Julian Ventura <[email protected]> Co-authored-by: avilagaston9 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements EIP-7002 and EIP-7251, enabling new execution layer requests.
Feature branch was used in order to pass L2 tests, see related issue #1917
Closes #1788, #1790