fix(l1, l2): temporary fix to L1 dev and L2 block producer #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilitteri
commented
Feb 24, 2025
There was a problem hiding this comment.
This file is the same but without the pectraTime and formatted.
|
Total lines added: 0 |
mpaulucci
approved these changes
Feb 24, 2025
|
Closed since the changes were included in #1705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Rejecting
V3engine API methods when Pectra is enabled broke both L1 dev and L2 block producer since they rely on these methods. As this is a side effect of not supporting the Pectra engine API methods on theEngineClient, a temporary solution is to disable Pectra for both L1 dev and L2 block producer until the new methods are implemented in theEngineClient(an issue was already filed for tackling this #2054).Description
As #2054 suggests, this PR disables Pectra for L1 dev and L2 by adding a temporary L1 genesis for dev mode and disables Pectra for L2's genesis.