fix(l1): validate incoming payloads even when the node is syncing. #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
mpaulucci
commented
Apr 8, 2025
fmoletta
reviewed
Apr 9, 2025
fmoletta
reviewed
Apr 9, 2025
…ntly syncing." This reverts commit f0474ba.
…to fix-invalid-payload-tests
…to fix-invalid-payload-tests
fmoletta
reviewed
Apr 15, 2025
…to fix-invalid-payload-tests
mpaulucci
force-pushed
the
fix-invalid-payload-tests
branch
from
e042c40 to
461efbf
Compare
fmoletta
approved these changes
Apr 22, 2025
jrchatruc
approved these changes
Apr 23, 2025
avilagaston9
pushed a commit
that referenced
this pull request
Apr 23, 2025
…2426) **Motivation** We should be able to do payload validations even when the node is in a sync process (except if it's snap sync). **Description** - Refactored some code to make it flatter - Removed early return when the node is syncing - minor renames for clarity sake.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
…sync hive test (#2605) **Motivation** PR #2426 changed how fork choice & new payload interact with the syncer and also introduced a bug. If snap sync is enabled, then fork choice update will never attempt to trigger a sync, so the sync process never gets started. This PR fixes the bug and also refactors the sync manager api to better suit the new use cases <!-- Why does this pull request exist? What are its goals? --> * Combine commonly used together `SyncManager` methods `set_head` & `start_sync` into `sync_to_head` * Remove unused `SyncManager` method `status` and associated struct * Make sure sync is triggered during fcu when needed even if snap sync is enabled * Re-enable snap sync hive test suite **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #2521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should be able to do payload validations even when the node is in a sync process (except if it's snap sync).
Description