Skip to content

fix(levm): apply forkchoice with levm #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(levm): apply forkchoice with levm #2499

wants to merge 1 commit into from

Conversation

ilitteri
Copy link
Contributor

@ilitteri ilitteri commented Apr 21, 2025 •
edited
Loading

Motivation

Fork choices were not being applied when using LEVM.

Description

Apply fork choice when using LEVM.

@ilitteri ilitteri self-assigned this Apr 21, 2025
@ilitteri ilitteri added the levm Lambda EVM implementation label Apr 21, 2025
@github-actions GitHub Actions
Copy link

Lines of code report

Total lines added: 0
Total lines removed: 7
Total lines changed: 7

Detailed view 
+----------------------------------------+-------+------+
| File                                   | Lines | Diff |
+----------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs | 506   | -7   |
+----------------------------------------+-------+------+

@ilitteri ilitteri marked this pull request as ready for review April 21, 2025 14:36
@ilitteri ilitteri requested a review from a team as a code owner April 21, 2025 14:36
mpaulucci
mpaulucci requested changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@mpaulucci mpaulucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this also fixes it and does other changes: #2452

can you review this one?

@ilitteri
Copy link
Contributor Author

Actually, this also fixes it and does other changes: #2452

can you review this one?

You are right! Closing this PR.

@ilitteri ilitteri closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpaulucci mpaulucci mpaulucci requested changes

Assignees

@ilitteri ilitteri

Labels
levm Lambda EVM implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilitteri @mpaulucci