Skip to content

feat(l2): correctly monitor withdrawal status #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

iovoid
Copy link
Contributor

@iovoid iovoid commented Jul 14, 2025

Motivation

We want to correctly track the status of withdrawals.

Description

Fetches the message id associated with the withdrawal by looking at the receipts of the transaction.

How to test

  • Add --monitor to the init-l2-no-metrics target in crates/l2/Makefile.
  • Run a Sequencer (I suggest make restart in crates/l2).
  • Run the prover with make init-prover in crates/l2.
  • Run make test in crates/l2.

Closes #3513

@iovoid iovoid requested a review from a team as a code owner July 14, 2025 14:53
@github-actions github-actions bot added the L2 Rollup client label Jul 14, 2025
Copy link

github-actions bot commented Jul 14, 2025

Lines of code report

Total lines added: 38
Total lines removed: 0
Total lines changed: 38

Detailed view
+------------------------------------------------------+-------+------+
| File                                                 | Lines | Diff |
+------------------------------------------------------+-------+------+
| ethrex/crates/l2/monitor/widget/l2_to_l1_messages.rs | 276   | +32  |
+------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/errors.rs                 | 319   | +6   |
+------------------------------------------------------+-------+------+

@gianbelinche
Copy link
Contributor

Please put the target branch to refactor/monitor-expects so only the changes specific of this PR are shown, and add to the description that the other PR should be merged first

@iovoid iovoid moved this to In Progress in ethrex_l2 Jul 14, 2025
@iovoid iovoid changed the base branch from main to refactor/monitor-expects July 14, 2025 19:58
@iovoid iovoid moved this from In Progress to In Review in ethrex_l2 Jul 16, 2025
Base automatically changed from refactor/monitor-expects to main July 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 Rollup client
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

L2 Monitor: Update L2 to L1 messages status correctly
2 participants