feat(l1): add gas used diff in error #3644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
approved these changes
Jul 15, 2025
Lines of code reportTotal lines added: Detailed view |
JereSalo
approved these changes
Jul 15, 2025
crates/blockchain/blockchain.rs
Outdated
Comment on lines
940
to
941
| // dbg!(last.cumulative_gas_used); | ||
| // dbg!(block_header.gas_used); |
There was a problem hiding this comment.
We can remove this if you want to, what you did serves as a replacement for this
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
**Motivation** When there's a gas mismatch, there's no way to tell what is the mismatch unless we print it manually. If it's present in the error, at least it appears in the test logs when it happens. **Description** - Adds used and expected fields for the GasUsedMismatchError. - Adds the fields in the block gas post-exec validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When there's a gas mismatch, there's no way to tell what is the mismatch unless we print it manually. If it's present in the error, at least it appears in the test logs when it happens.
Description