-
Notifications
You must be signed in to change notification settings - Fork 82
refactor(l1): parallelize request_block_headers
function
#3650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ricomateo
wants to merge
13
commits into
main
Choose a base branch
from
parallelize-request_block_headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view
|
mpaulucci
reviewed
Jul 16, 2025
if are_block_headers_chained(&block_headers, &order) { | ||
return Some(block_headers); | ||
} else { | ||
warn!("[SYNCING] Received invalid headers from peer"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if:
- One peer is very slow and times out. All blocks will be discarded?
- Same question but if a peer returns invalid blocks or blocks from another chain?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
request_block_headers
function is quite slow due to its sequential approach, since it queries block headers from one peer at a time, waiting for a response from one peer (it currently waits up to 15 seconds) before trying the next.This makes the process very slow since some peers may return invalid data, or they may even not respond.
Description
This PR modifies the
request_block_headers
function to request the block headers to multiple peers in parallel instead of querying them sequentially. With this approach the node no longer waits for one peer to respond before querying the next one. Instead, all the peers are queried simultaneously, and the first valid response is returned, significantly speeding up the process.Closes: None