fix(l2): flamegraph and benchmark workflows #3652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the reth flamegraph workflow by adding a missing dependency. The workflow was failing because it required the Solidity compiler (solc) but didn't have it installed.
- Adds solc installation step to the flamegraph-reth job
- Uses pontem-network/get-solc action to install solc version v0.8.29
LeanSerra
approved these changes
Jul 16, 2025
mpaulucci
requested changes
Jul 16, 2025
github-project-automation
bot
moved this from In Review
to Requires Changes
in ethrex_l2
avilagaston9
changed the title
mpaulucci
approved these changes
Jul 16, 2025
avilagaston9
added a commit
that referenced
this pull request
Jul 16, 2025
This reverts commit 77b2819.
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
**Motivation** Install solc to `flamegraph-reth` job. Successful run [here](https://github.com/lambdaclass/ethrex/actions/runs/16305540602/job/46050676065?pr=3652). Closes None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Install solc to
flamegraph-rethjob. Successful run here.Closes None