refactor(l1): remove Mutex from profiling metrics
#5031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the profiling metrics implementation by removing a centralized Mutex that could cause contention as more functions are instrumented. The change leverages per-span RwLock mechanisms already present in the tracing infrastructure.
Key changes:
- Replaced the
HashMap<Id, HistogramTimer>wrapped in aMutexwith per-span storage using span extensions - Introduced a
ProfileTimerwrapper struct to avoid conflicts with other layers - Updated instantiation to use unit struct instead of
default()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/blockchain/metrics/profiling.rs | Removed centralized Mutex-protected HashMap and implemented per-span timer storage using span extensions |
| cmd/ethrex/initializers.rs | Updated FunctionProfilingLayer instantiation to use unit struct syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Lines of code reportTotal lines added: Detailed view |
mpaulucci
approved these changes
Oct 24, 2025
edg-l
approved these changes
Oct 27, 2025
iovoid
pushed a commit
that referenced
this pull request
Oct 27, 2025
**Motivation** Having a centralized `Mutex` in the profiling metrics could potentially make code slower, the more functions we instrument. Removing it reduces the noise we have in our measurements. **Description** This PR replaces the singleton `Mutex` by using the internal `RwLock` that spans already have for layers to store things. Disabling metrics doesn't seem to increase performance in a noticeable manner, so this shouldn't increase performance. --------- Co-authored-by: Edgar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having a centralized
Mutexin the profiling metrics could potentially make code slower, the more functions we instrument. Removing it reduces the noise we have in our measurements.Description
This PR replaces the singleton
Mutexby using the internalRwLockthat spans already have for layers to store things. Disabling metrics doesn't seem to increase performance in a noticeable manner, so this shouldn't increase performance.