-
Couldn't load subscription status.
- Fork 114
chore(l1): review p2p logs #5046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+176
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
ElFantasma
reviewed
Oct 24, 2025
ElFantasma
reviewed
Oct 24, 2025
ElFantasma
reviewed
Oct 24, 2025
ElFantasma
reviewed
Oct 24, 2025
ElFantasma
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Left some minor suggestions
Co-authored-by: ElFantasma <[email protected]>
edg-l
approved these changes
Oct 27, 2025
MegaRedHand
approved these changes
Oct 27, 2025
ElFantasma
reviewed
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the P2P logs are verbose, and don't use the structured format we want for logs in some cases. As such, we aim in this PR to review and change the format of the logs.
Description
"Broken pipe with peer, disconnected"from error to debugExample of output in this PR:
2025-10-24T17:59:52.294734Z DEBUG ethrex_p2p::rlpx::connection::server: connection failure peer=Nethermind:0xb7b2…10fb(70.105.250.99:30303) error_text=Failed to initialize RLPx connection error=Peer disconnected due to: Too Many Peers