Skip to content

perf(l1,l2): remove latest_block_header lock #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

perf(l1,l2): remove latest_block_header lock #5050

wants to merge 7 commits into from

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Oct 24, 2025

chain_config is a matter of initialization with mutable stores, while
latest_block_header is replaced by an ArcSwap to allow lock-free
swapping with new values.

Motivation

Description

Closes #issue_number

@Oppen
perf(l1,l2): remove latest_block_header and chain_config locks
d319a85 
chain_config is a matter of initialization with mutable stores, while
latest_block_header is replaced by an ArcSwap to allow lock-free
swapping with new values.
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client performance labels Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

Lines of code report

Total lines added: 0
Total lines removed: 34
Total lines changed: 34

Detailed view 
+--------------------------------+-------+------+
| File                           | Lines | Diff |
+--------------------------------+-------+------+
| ethrex/crates/storage/store.rs | 1499  | -34  |
+--------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 76.806 ± 0.447 76.084 77.837 1.00
head 77.222 ± 0.264 76.765 77.678 1.01 ± 0.01

@jrchatruc jrchatruc changed the title perf(l1,l2): remove latest_block_header and chain_config locks perf(l1,l2): remove latest_block_header lock Oct 28, 2025
@jrchatruc jrchatruc marked this pull request as ready for review October 28, 2025 20:12
@jrchatruc jrchatruc requested a review from a team as a code owner October 28, 2025 20:12
Copilot AI review requested due to automatic review settings October 28, 2025 20:29
Copilot AI reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@Oppen Oppen

Labels

L1 Ethereum client L2 Rollup client performance

Projects

ethrex_l1
Status: No status
ethrex_l2
Status: No status
ethrex_performance
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Oppen @iovoid