fix(l1): fix InvalidPayloadAttributes RPC error message #5701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Invalid message for InvalidPayloadAttributes
In impl From for RpcErrorMetadata branch RpcErr::InvalidPayloadAttributes(data) sets
which contradicts the variant itself (InvalidPayloadAttributes) and the adjacent InvalidForkChoiceState.
Description
The InvalidPayloadAttributes RpcErr variant was incorrectly mapped to the "Invalid forkchoice state" message while keeping the -38003 error code. This change aligns the message with the Engine API specification ("Invalid payload attributes") and avoids confusing it with InvalidForkChoiceState errors, without altering error codes or behavior in the surrounding validation logic.