Skip to content

Conversation

@edg-l
Copy link
Contributor

@edg-l edg-l commented Dec 23, 2025

Motivation

don't apply apply_trie_updates for blocks that don't update state

this avoids triggering the error log:

 else if parent == state_root {
            tracing::error!("Inconsistent state: parent == state_root but key_values not empty");
            return;
        }

from put_batch in the trie, which shows on the block benchmark ci (triggered by having perf in the title)

Tested with a hoodi snap synced node and works

Checklist

  • Updated STORE_SCHEMA_VERSION (crates/storage/lib.rs) if the PR includes breaking changes to the Store requiring a re-sync.

Closes #5710

@github-actions github-actions bot added L1 Ethereum client performance Block execution throughput and performance in general labels Dec 23, 2025
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

Lines of code report

Total lines added: 6
Total lines removed: 0
Total lines changed: 6

Detailed view
+--------------------------------+-------+------+
| File                           | Lines | Diff |
+--------------------------------+-------+------+
| ethrex/crates/storage/store.rs | 2593  | +6   |
+--------------------------------+-------+------+

@edg-l edg-l marked this pull request as ready for review December 23, 2025 14:38
@edg-l edg-l requested a review from a team as a code owner December 23, 2025 14:38
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client performance Block execution throughput and performance in general

Projects

Status: In Review
Status: Todo

Development

Successfully merging this pull request may close these issues.

Benchmark Block Execution fails CI always

2 participants