Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input check on BabySnark #960

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Add input check on BabySnark #960

merged 3 commits into from
Jan 28, 2025

Conversation

jotabulacios
Copy link
Contributor

@jotabulacios jotabulacios commented Jan 13, 2025

Add input check on BabySnark

Description

This PR adds an additional check to the input values to ensure that the first element of the input is 1. This constraint is necessary to maintain the consistency of quadratic constraints

The variable public must be 1 because it is the first element of the input that the prover receives. For a more detailed explanation, refer to the BabySNARK paper.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.40%. Comparing base (3b16015) to head (5ec2238).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files         155      155           
  Lines       33574    33574           
=======================================
  Hits        23975    23975           
  Misses       9599     9599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotabulacios jotabulacios marked this pull request as ready for review January 13, 2025 20:18
@jotabulacios jotabulacios requested a review from a team as a code owner January 13, 2025 20:18
@jotabulacios jotabulacios added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 1e64f0a Jan 28, 2025
8 checks passed
@jotabulacios jotabulacios deleted the improve_babysnark_example branch January 28, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants