Skip to content
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bbd7db9
Make address optional in transaction data
IAvecilla Sep 11, 2024
ddc35de
Improve get contract address for sql queries
IAvecilla Sep 12, 2024
cf454e2
Merge branch 'main' into tx-to-optional-address
IAvecilla Sep 12, 2024
a5c22ea
Make recipient address optional for L2Tx
IAvecilla Sep 12, 2024
c075fb4
Fix error lints
IAvecilla Sep 12, 2024
6c94de9
Insert null in sql for contract address instead of empty bytes
IAvecilla Sep 17, 2024
b280eb3
Remove require and support None value for protobuff Transaction
IAvecilla Sep 17, 2024
d49f3f8
Make address optional for Transaction recipient account
IAvecilla Sep 17, 2024
5e9179d
Optionally add contract address to transaction signature
IAvecilla Sep 17, 2024
0034e3e
Check address is not null and reject transaction
IAvecilla Sep 17, 2024
d9e2b9a
Merge branch 'main' into tx-to-optional-address
IAvecilla Sep 17, 2024
9c3dad1
Make test only Execute to always have a valid address instead of null
IAvecilla Sep 17, 2024
9652368
Update execute use for tests in multivm crate to have a valid contrac…
IAvecilla Sep 17, 2024
dab1eb2
feat(ci): Deprecate use of zk tool in docker-build process (#2901)
artmakh Sep 18, 2024
20442f6
test: Investigate L1 "nonce too low" errors (#2848)
slowli Sep 18, 2024
ba21c6e
fix(ci): vm perf to prometheus (#2909)
Deniallugo Sep 18, 2024
5cb04ed
feat(ci): Add building base docker image (#2913)
artmakh Sep 18, 2024
189e591
Update comment for optional field in execute proto message
IAvecilla Sep 18, 2024
8729270
fix(ci): Fix multiarch for build-base CI (#2914)
artmakh Sep 18, 2024
2ac399e
Unwrap contract address for l1 tx since it should always be present
IAvecilla Sep 18, 2024
6be103f
Merge branch 'main' into tx-to-optional-address
IAvecilla Sep 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unwrap contract address for l1 tx since it should always be present
  • Loading branch information
IAvecilla committed Sep 18, 2024
commit 2ac399e174d4f53c3c94f02e5c128fbb7e6bcea6
4 changes: 3 additions & 1 deletion core/lib/types/src/l1/mod.rs
Original file line number Diff line number Diff line change
@@ -274,7 +274,9 @@ impl From<L1Tx> for abi::NewPriorityRequest {
transaction: abi::L2CanonicalTransaction {
tx_type: PRIORITY_OPERATION_L2_TX_TYPE.into(),
from: address_to_u256(&t.common_data.sender),
to: address_to_u256(&t.execute.contract_address.unwrap_or_default()),
// Unwrap used here because the contract address should always be present for L1 transactions.
// TODO: Consider restricting the contract address to not be optional in L1Tx.
to: address_to_u256(&t.execute.contract_address.unwrap()),
gas_limit: t.common_data.gas_limit,
gas_per_pubdata_byte_limit: t.common_data.gas_per_pubdata_limit,
max_fee_per_gas: t.common_data.max_fee_per_gas,