feat(eigen-client-extra-features): address comments #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianbelinche
requested changes
Feb 6, 2025
| pub enum PointsSource { | ||
| Path(String), | ||
| /// g1_url, g2_url | ||
| Link((String, String)), |
There was a problem hiding this comment.
Link is not a great name, maybe use Url
Comment on lines
40
to
43
| message Path { | ||
| optional string path = 1; | ||
| } | ||
|
|
Comment on lines
110
to
129
| const DEFAULT_EIGENDA_SVC_MANAGER_ADDRESS: H160 = H160([ | ||
| 0xd4, 0xa7, 0xe1, 0xbd, 0x80, 0x15, 0x05, 0x72, 0x93, 0xf0, 0xd0, 0xa5, 0x57, 0x08, 0x8c, 0x28, | ||
| 0x69, 0x42, 0xe8, 0x4b, | ||
| ]); | ||
|
|
||
| fn test_eigen_config() -> EigenConfig { | ||
| EigenConfig { | ||
| disperser_rpc: "https://disperser-holesky.eigenda.xyz:443".to_string(), | ||
| settlement_layer_confirmation_depth: 0, | ||
| eigenda_eth_rpc: Some(SensitiveUrl::from_str("https://ethereum-holesky-rpc.publicnode.com").unwrap()), // Safe to unwrap, never fails | ||
| eigenda_svc_manager_address: DEFAULT_EIGENDA_SVC_MANAGER_ADDRESS, | ||
| wait_for_finalization: false, | ||
| authenticated: false, | ||
| points_source: PointsSource::Link(( | ||
| "https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g1.point".to_string(), | ||
| "https://github.com/Layr-Labs/eigenda-proxy/raw/2fd70b99ef5bf137d7bbca3461cf9e1f2c899451/resources/g2.point.powerOf2".to_string(), | ||
| )) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Why do you need this function twice? can't you make it public and share it
There was a problem hiding this comment.
I have moved the function into mod.rs so it can be accessed from both files
gianbelinche
approved these changes
Feb 7, 2025
juanbono
approved these changes
Feb 7, 2025
gianbelinche
merged commit 34df5ff
into
eigen-client-extra-features
11 of 24 checks passed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.