Skip to content

Added QueryStringQuery #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added QueryStringQuery #648

wants to merge 2 commits into from

Conversation

JuliaIlic
Copy link

No description provided.

@JuliaIlic JuliaIlic force-pushed the QueryStringQuery-Branch branch from 4b0456e to 653706e Compare June 13, 2025 08:20
drmarjanovic
drmarjanovic requested changes Jun 13, 2025
View reviewed changes
modules/library/src/test/scala/zio/elasticsearch/ElasticQuerySpec.scala Outdated
test("queryStringQuery"){
val query = range("testField")
val queryNoFields = queryStringQuery("test")
val queryWithFields = queryStringQuery("test").fields("stringField1", "stringField2")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide queryWithFields where fields aren't plain strings.

modules/library/src/test/scala/zio/elasticsearch/ElasticQuerySpec.scala
val queryWithFields = queryStringQuery("test").fields("stringField1", "stringField2")
val queryWithMinShouldMatch = queryNoFields.minimumShouldMatch(2)

},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing an assertion here.

drmarjanovic
drmarjanovic requested changes Jun 13, 2025
View reviewed changes
Copy link
Member

@drmarjanovic drmarjanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, additionally:

  • Please use better PR title
  • Link the issue you're resolving in description
  • Format your code before pushing it - you can use sbt prepare

dbulaja98
dbulaja98 requested changes Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@dbulaja98 dbulaja98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first PR.

Just few things:

  • You are missing some integrations tests
  • You are missing documentation page for this query

modules/library/src/main/scala/zio/elasticsearch/ElasticQuery.scala Outdated
* @return
* an instance of [[zio.elasticsearch.query.QueryStringQuery]] that represents the query to be performed.
*/
final def queryStringQuery[S: Schema](query: String, fields: Field[S, _]*): QueryStringQuery[S] =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this fields parameter can be empty list, maybe we shouldn't ask for it here. In other method you don't have it as parameter, so I would do it like this here too.

drmarjanovic
drmarjanovic requested changes Jun 14, 2025
View reviewed changes
Copy link
Member

@drmarjanovic drmarjanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several things are missing:

  • website docs
  • integration tests

Besides that, let's rename a method and link to the issue properly.

modules/library/src/main/scala/zio/elasticsearch/ElasticQuery.scala
* @return
* an instance of [[zio.elasticsearch.query.QueryStringQuery]] that represents the query to be performed.
*/
final def queryStringQuery[S: Schema](query: String, fields: Field[S, _]*): QueryStringQuery[S] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense for fields to be empty?

modules/library/src/main/scala/zio/elasticsearch/query/Queries.scala
def fields(field: String, fields: String*): QueryStringQuery[S] =
self.copy(fields = Chunk.fromIterable(field +: fields))

def fields(fields: Chunk[String]): QueryStringQuery[S] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

modules/library/src/main/scala/zio/elasticsearch/query/Queries.scala

private[elasticsearch] def toJson(fieldPath: Option[String]): Json = {
val fieldsJson =
if (fields.nonEmpty) Some("fields" -> Arr(fields.map(Str(_))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use .map here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmarjanovic drmarjanovic drmarjanovic requested changes

@dbulaja98 dbulaja98 dbulaja98 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuliaIlic @drmarjanovic @dbulaja98