(dsl): Support IP range aggregation #650
Open
+411
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, type-safe and regular def in ElastocAggregation without description
Mitep
suggested changes
Jun 19, 2025
There was a problem hiding this comment.
This file still have issues with format, and also it has special ^M characters
modules/integration/src/test/scala/zio/elasticsearch/IntegrationSpec.scala
Outdated
Show resolved
Hide resolved
| @@ -4,9 +4,9 @@ | |||
| * Licensed under the Apache License, Version 2.0 (the "License"); | |||
| * you may not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * | |||
drmarjanovic
requested changes
Jun 19, 2025
modules/integration/src/test/scala/zio/elasticsearch/HttpExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/zio/elasticsearch/HttpExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/zio/elasticsearch/HttpExecutorSpec.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticAggregation.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/aggregation/Aggregations.scala
Outdated
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/aggregation/Aggregations.scala
Show resolved
Hide resolved
| from = b.from, | ||
| to = b.to, | ||
| docCount = b.docCount, | ||
| subAggregations = Map.empty |
There was a problem hiding this comment.
@dbulaja98, up there, we have withSubAggregations. Is this correct implementation then?
modules/library/src/test/scala/zio/elasticsearch/ElasticAggregationSpec.scala
Outdated
Show resolved
Hide resolved
|
An additional note:
|
drmarjanovic
requested changes
Jun 20, 2025
modules/library/src/main/scala/zio/elasticsearch/ElasticAggregation.scala
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/ElasticAggregation.scala
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/aggregation/Aggregations.scala
Show resolved
Hide resolved
modules/library/src/main/scala/zio/elasticsearch/aggregation/Aggregations.scala
Show resolved
Hide resolved
| subAggregations: Option[Chunk[SingleElasticAggregation]] | ||
| ) extends IpRangeAggregation { self => | ||
|
|
||
| def keyedOn: IpRangeAggregation = self.copy(keyed = Some(true)) |
There was a problem hiding this comment.
I guess we can use only keyed.
drmarjanovic
requested changes
Jun 20, 2025
|
|
||
| def key(value: String): IpRangeBound = self.copy(key = Some(value)) | ||
|
|
||
| def toJson: Json = { |
There was a problem hiding this comment.
Can we put private[elasticsearch] here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118