Add a health check to the Dockerfile

[egguy]

Allow to detect it there's problem with the nginx process and restart it.
Use the /lancache-heartbeat URL to check.

Based on: https://scoutapm.com/blog/how-to-use-docker-healthcheck

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[VibroAxe]

Nice improvement, i've been meaning to do this forever!
We should probably define some start's and intervals. How about?
HEALTHCHECK --interval=1m --timeout=1s --start-period=120s --retries=3 CMD curl -f http://localhost/ || exit 1

[VibroAxe]

@egguy Sorry for the delay in this, it's been a pretty hectic time. Nice idea, see comment on the review, i'd love to implement this

[egguy]

I've updated the pull with your recommendations.

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

[egguy]

Hello @VibroAxe, I hope it's not tool late, could I request a review, or there are some remaining changes to do ?

[VibroAxe]

Hey, certainly. Apologies but code review has taken a bit of a back seat. I'll take a look

[egguy]

No worries, It was my bad too, I was too late to react to prevent closure from the bot.

Thx for taking time and maintaining this project

PS: Is it possible to also take a look ad #147 to allow the test to work again ?

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

[PotcFdk]

@VibroAxe is there a reason why Pull Requests keep getting auto-closed by the bot? I see how there could be a valid reason for issues, but IMO PRs can just stay open until a developer/maintainer decides it doesn't make sense to pursue them further. Autoclosing them because "hurr durr it's inactive" even though what's missing can't even be delivered by the author of the PR is a bit irritating.

[VibroAxe]

Fair comment. I'll see if I can stop the bot idling out on PRs

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[PotcFdk]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bump

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jobhh]

Any progress on not idling out on PRs? :p

[stale]

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically closed after being inactive for 30 days. If you require further assistance please reopen the issue with more details or talk to us on discord

[PotcFdk]

Can this be reopened?

[tpill90]

@VibroAxe Looks like this is another valid one that just got lost in the mix.