Audio refactor #178
Open
Audio refactor #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for dynamic reconfiguraton of drop rate - Remove methods and events associates with runtime reconfiguration - Fix minor bug in dissemination of data rate
- Refactor to have a common base class - Standardize implementation - reduce duplicted code n.b. this is a first cut, compiling but untestsed code.
Compiles, but not tested.
- add - bugfix
Comment on lines
-255
to
-261
| float StreamRecording::getSampleRate() | ||
| { | ||
| if( this->lastUpstreamRate == DATASTREAM_SAMPLE_RATE_UNKNOWN ) | ||
| return this->upStream.getSampleRate(); | ||
|
|
||
| return this->lastUpstreamRate; | ||
| } |
There was a problem hiding this comment.
The StreamRecording::getSampleRate() method has been removed by the virtual float getSampleRate() declaration has been left in StreamRecording.h, which causes a compilation error.
- simplified structure
- removed old/redundant functions
- utilised audio-refactor APIs
- implemented copy-mode recording (as yet untested) for smaller blocks.
Known working with the following program:
int main()
{
uBit.init();
uBit.audio.requestActivation();
SplitterChannel *channel = uBit.audio.splitter->createChannel();
StreamRecording *recording = new StreamRecording(*channel);
MixerChannel * mix = uBit.audio.mixer.addChannel(*recording);
recording->record();
mix->setSampleRate(11000);
uBit.sleep(1000);
while(1)
{
DMESG("PLAYING...");
recording->play();
DMESG("DONE.");
uBit.sleep(10000);
}
}
| void initialise(); | ||
| uint32_t totalBufferLength; // Amount of data currently stored in this object. | ||
| int state; // STOPPED/PLAYING/RECORDING. | ||
| ManagedBuffer data[CODAL_STREAM_RECORDING_SIZE]; // Buffers of data, each CODAL_STREAM_RECORDING_BUFFER_SIZE in length. |
There was a problem hiding this comment.
This is going to statically allocate an array of 200 items, so in the absolute best case scenario of an empty ManagedBuffer being only 4 bytes, that's 800 bytes consumed here (or a multiple of that if each instance is larger).
- remove excessive debug information - makeif statements positive, not negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready to merge. Raising this PR for review purposes only.