Draft
Conversation
e3319f4 to
df09b08
Compare
df09b08 to
7adab7c
Compare
Signed-off-by: Raphael Gault <[email protected]> Merged CMakeLists.txt target link libraries with master - includes relevant CMSIS libraries.
Signed-off-by: Raphael Gault <[email protected]>
Signed-off-by: Raphael Gault <[email protected]>
…BitAudioProcessor and sample fft C++ Program
7adab7c to
b40eed7
Compare
Although it currently calculates frequencies that are twice the signal frequency, but that might be a simple fix once somebody can look into the audio configuration.
b40eed7 to
22920ba
Compare
3d6888d to
cc0d402
Compare
cc0d402 to
b6dca85
Compare
Build diffBase commit: be35cc1d13697a783e08658a94e3af2b6c1afc4e |
3 tasks
Collaborator
Author
|
Next steps for this work:
|
Collaborator
Author
|
When using this branch for the first time, the CMSIS_5 git clone might sometimes produce the following error: This can be fixed by using the # First delete the libraries folder so build.py clones all repos from scratch
rm -rf build/
# This flag skips trying to download any of the git LFS files, which we don't need for the FFT
GIT_LFS_SKIP_SMUDGE=1 python build.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving the branch originally developed by Raphael and updated by Joshua.
This is not really mergeable on this state as the CMSIS libs are added as a submodule to this repo and it changes the
float-abicompiler flag tohard(we need to check if we can compile the CMSIS DSP code withfloat-abit=softfp).Maybe it's worth considering moving this as a "CODAL library" that can also be used as a MakeCode extension, as the
MicroBitAudioProcessorclass is a fairly self-containedDataSink.I'm not sure if I've wired the right DataSource to
MicroBitAudioProcessoras a I get a lot high frequency values in a relatively quiet room (do we have a DataSource that has filtered out noise?) and the calculated frequencies are twice as expected.codal-microbit-v2/samples/fft_example.cpp
Lines 18 to 37 in e3319f4
Also, it looks like CMSIS needs CMake 3.13 min, and that's a newer version than the Yotta docker image, so the MakeCode builds will fail.