Skip to content

Stm32f1 v0#13

Open
jamesadevine wants to merge 7 commits intomasterfrom
stm32f1-v0
Open

Stm32f1 v0#13
jamesadevine wants to merge 7 commits intomasterfrom
stm32f1-v0

Conversation

@jamesadevine
Copy link
Contributor

commits that enable jacdac-v0 on stm32f1

@jamesadevine jamesadevine requested a review from mmoskal May 30, 2019 23:56
this->timer_instance = timer;
this->irqN = irqn;
memset(&TimHandle, 0, sizeof(TIM_HandleTypeDef));
disableIRQ();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

// USB_HP_CAN1_TX_IRQn
// USB_LP_CAN1_RX_IRQn

NVIC_SetPriority(USB_LP_CAN1_RX0_IRQn, 5);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and ifdef


static int enable_clock(uint32_t instance)
{
DMESG("CLK EN");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

return HAL_RCC_GetPCLK1Freq();
case USART3_BASE:
__HAL_RCC_USART3_CLK_ENABLE();
DMESG("PCLK1 %d", HAL_RCC_GetPCLK1Freq());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dmesg

pin_mode(pin, PullNone);
// pin_mode(pin, PullNone);
pin_function(pin, pinmap_function(pin, PinMap_UART_TX));
pin_mode(pin,PullUp);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check this pin mode business

this->bufLen = len;

int res = HAL_UART_Transmit_DMA(&uart, data, len);
DMESG("TXDMA RES %d ",res);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

#ifndef USB
USBx_DEVICE->DIEPEMPMSK &= ~0x1U << ep;

while (!(USB_ReadDevInEPInterrupt(pcd.Instance, ep) & USB_OTG_DIEPINT_XFRC))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check usb works overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments