build.py 'cmake-build-type' argument for cmake #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with the '-DCMAKE_BUILD_TYPE=`value`' argument
kawaiicvnt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for your awesome work on this!
As I was working on my thesis, I noticed that some values on the debugger were getting optimized out. After digging into this, I noticed that the only build type was RelWithDebInfo.
Since I was already adding the functionality for my use-case, I thought I'd push it upstream :3
Details:
Added the 'cmake-build-type' argument which passes the value to cmake with the '-DCMAKE_BUILD_TYPE=`value`' argument
Usage: ./build.py [--cmake-build-type ...]
It only accepts valid values (Debug, Release, MinSizeRel, RelWithDebInfo) and exits with an error for wrong values.
Default value is 'RelWithDebInfo', to match current behavior.