Feature/bootstrap #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully can diagnose why travis is breaking...
It misleadingly implies the combination of only two hex files when it can in fact handle many more.
Allow for additional "libraries": [] in codal.json
Account for main being used instead of master in lock code
The pre-process task executes before a build occurs
call_cmake now preserves permissions when copying files. FORM_SHELL_COMMMAND function now used for post process too!
Add pre-process task
|
This is pending lancaster-university/codal#45 |
|
We should also considered if this is needed before adopting bootstrap: |
Comment on lines
185
to
+191
|
|
||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -include \"${EXTRA_INCLUDES_PATH}\"") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -include \"${EXTRA_INCLUDES_PATH}\"") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -include ${EXTRA_INCLUDES_PATH}") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -include ${EXTRA_INCLUDES_PATH}") | ||
| endif() | ||
|
|
||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -I\"${PLATFORM_INCLUDES_PATH}\"") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -I\"${PLATFORM_INCLUDES_PATH}\"") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -I${PLATFORM_INCLUDES_PATH}") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -I${PLATFORM_INCLUDES_PATH}") |
There was a problem hiding this comment.
This is undoing PR #10
|
Closing this PR to draft a new one with the updated repo(s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the samples repository to use codal-bootstrap to build rather than bare build.py, so we can update the build tools independently from the project sources.
Build function for users should be the same, although the readme may need updating to match the new functions available.