compat,lib: add basic support for ABI v7, add support for restrict_self log flags - #117
Closed
stevennyman wants to merge 1 commit into
Closed
compat,lib: add basic support for ABI v7, add support for restrict_self log flags#117stevennyman wants to merge 1 commit into
stevennyman wants to merge 1 commit into
Conversation
Author
|
This is required by landlock-lsm/island#13 |
…lf log flags Signed-off-by: Steven Nyman <35897452+stevennyman@users.noreply.github.com>
Author
|
I pushed an updated version of the commit that corrects the formatting. I'm unsure regarding the Rust 1.68 version support issue with one of the dependencies of the dependencies. |
l0kod
reviewed
Apr 10, 2026
l0kod
left a comment
l0kod
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I started to work on this task some time ago but it require a new kind of interface specific to the new flags. I updated this work and I'll create another PR.
| /// | ||
| /// On error, returns a wrapped [`RestrictSelfError`]. | ||
| pub fn restrict_self(mut self) -> Result<RestrictionStatus, RulesetError> { | ||
| pub fn restrict_self_with_flags( |
Member
There was a problem hiding this comment.
This is a breaking change, we need a smoother interface.
| LogSubdomainsOff = uapi::LANDLOCK_RESTRICT_SELF_LOG_SUBDOMAINS_OFF, | ||
| } | ||
|
|
||
| impl Access for RestrictSelfFlag { |
Member
There was a problem hiding this comment.
Syscall flags are not the same semantic as access rights.
Member
Member
|
Duplicate of #120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.