feat: add delete_file tool to FilesystemMiddleware #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comprehensive delete_file functionality to the filesystem middleware: - Implemented _delete_file_tool_generator with full support for both short-term (state) and long-term (store) memory - Added DELETE_FILE_TOOL_DESCRIPTION and longterm memory supplement - Updated FILESYSTEM_SYSTEM_PROMPT to include delete_file - Added delete_file to TOOL_GENERATORS dictionary - Updated FilesystemMiddleware docstring (four -> five tools) Test coverage: - test_delete_file_shortterm: Tests deletion from ephemeral state - test_delete_file_longterm: Tests deletion from persistent store - test_delete_file_not_found_shortterm: Error handling for missing files - test_delete_file_not_found_longterm: Error handling in longterm memory - Updated assert_longterm_mem_tools and assert_shortterm_mem_tools helpers Documentation: - Updated README.md to mention delete_file in Core Capabilities - Updated FilesystemMiddleware section with new tool listing The implementation follows existing patterns and provides feature parity with other filesystem tools including path validation, error handling, and support for custom descriptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comprehensive delete_file functionality to the filesystem middleware:
Test coverage:
Documentation:
The implementation follows existing patterns and provides feature parity with other filesystem tools including path validation, error handling, and support for custom descriptions.