Skip to content

Conversation

brucezo
Copy link

@brucezo brucezo commented Aug 29, 2025

No description provided.

Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchain Ready Ready Preview Comment Aug 29, 2025 5:20am

Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed WallTime Performance Report

Merging #32745 will not alter performance

Comparing brucezo:master (b5cafd1) with master (b26e52a)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Instrumentation Performance Report

Merging #32745 will not alter performance

Comparing brucezo:master (b5cafd1) with master (b26e52a)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy changed the title feat: To facilitate local embedding, make parameters 'tiktoken_enabled' and 'embedding_ctx_length' configurable feat(openai): make tiktoken_enabled and embedding_ctx_length configurable Aug 30, 2025
@mdrxy mdrxy added the integration Related to a provider partner package integration label Aug 30, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the motivation here? Preferably with a PR summary and/or a test demonstrating desired behavior. From what I can tell there is functionally no change here. Closing for now.

@ccurme ccurme closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Related to a provider partner package integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants