Skip to content

fix(core): preserve injected arguments when args_schema is BaseModel #33649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+9 −1
Closed

fix(core): preserve injected arguments when args_schema is BaseModel #33649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion libs/core/langchain_core/tools/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,9 +676,17 @@ def _parse_input(
f"args_schema must be a Pydantic BaseModel, got {self.args_schema}"
)
raise NotImplementedError(msg)
return {
validated_fields = {
k: getattr(result, k) for k, v in result_dict.items() if k in tool_input
}
# FIX FOR ISSUE #33646: Preserve injected arguments
# Add back injected arguments that were in original input but not in schema
for param_name, param_value in tool_input.items():
if param_name not in validated_fields:
# This could be an injected argument like ToolRuntime
validated_fields[param_name] = param_value

return validated_fields
return tool_input

@abstractmethod
Expand Down