fix: Add video support to convert_to_openai_data_block function #33654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added video block handling for base64, URLs, and file_ids - Support for both Chat Completions and Responses API formats - Proper error handling for unsupported combinations - Maintains consistency with existing audio/image handling patterns Fixes langchain-ai#33652
github-actions
bot
added
fix
core
CodSpeed Performance ReportMerging #33654 will improve performances by 20.26%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|---|
| ⚡ | WallTime | test_import_time[BaseChatModel] |
605.6 ms | 503.5 ms | +20.26% |
| ⚡ | WallTime | test_import_time[CallbackManager] |
523.4 ms | 442.4 ms | +18.3% |
| ⚡ | WallTime | test_import_time[ChatPromptTemplate] |
667.1 ms | 568.7 ms | +17.31% |
| ⚡ | WallTime | test_import_time[Document] |
206 ms | 182.8 ms | +12.68% |
| ⚡ | WallTime | test_import_time[HumanMessage] |
300.9 ms | 260.5 ms | +15.51% |
| ⚡ | WallTime | test_import_time[InMemoryRateLimiter] |
189.8 ms | 170.9 ms | +11.02% |
| ⚡ | WallTime | test_import_time[InMemoryVectorStore] |
692.1 ms | 587.5 ms | +17.8% |
| ⚡ | WallTime | test_import_time[LangChainTracer] |
493.1 ms | 421.6 ms | +16.96% |
| ⚡ | WallTime | test_import_time[PydanticOutputParser] |
604.2 ms | 509.4 ms | +18.61% |
| ⚡ | WallTime | test_import_time[RunnableLambda] |
541.9 ms | 473.9 ms | +14.33% |
| ⚡ | WallTime | test_import_time[Runnable] |
558.5 ms | 468.5 ms | +19.2% |
| ⚡ | WallTime | test_import_time[tool] |
567.1 ms | 495.1 ms | +14.52% |
Footnotes
-
21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds missing video support to the
convert_to_openai_data_blockfunction, addressing issue #33652.Changes
elif block["type"] == "video":handling in convert_to_openai_data_blockTesting
Tested all video input scenarios:
Fixes #33652