fix(core): implement ChatPromptTemplate.save() method #33676
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ChatPromptTemplate.save() Implementation
Summary
This PR fixes issue #32637 by enabling the
save()method forChatPromptTemplate, which was previously raisingNotImplementedError.Problem
Users were unable to save
ChatPromptTemplateinstances to disk, unlike other prompt types such asPromptTemplateandFewShotPromptTemplate. When calling.save(), the method would raise aNotImplementedError, preventing serialization to YAML or JSON files.Solution
The fix is straightforward: I removed the
save()method override that was raisingNotImplementedError. This allowsChatPromptTemplateto inherit the fully functionalsave()implementation from its parent classBasePromptTemplate.The parent class implementation already handles serialization correctly using:
self.dict()for converting the prompt to a dictionaryself._prompt_typeproperty (whichChatPromptTemplatealready implements, returning"chat")Changes
libs/core/langchain_core/prompts/chat.py(lines 1276-1283)Testing
ChatPromptTemplateinstances can now be saved to both YAML and JSON formatsImpact
After this change, users can:
ChatPromptTemplateto YAML files:chat_prompt.save("prompt.yaml")ChatPromptTemplateto JSON files:chat_prompt.save("prompt.json")Fixes #32637