Fix: respect base_url from config file when fetching thread with metadata …#34
Open
Jordan Kamm (jhkamm) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…and/or feedback
Problem
I noticed that the cli was attempting to fetch metadata for a thread from the default langsmith api url when I didn't have the LANGSMITH_ENDPOINT env var set, but I did have a config file setup with a custom
base-url.Fix / What Changed
base_urlwasn't getting passed to the langsmith Client instantiation when fetching metadata and/or feedback for a thread so I just passed the base_url along down the line