-
Notifications
You must be signed in to change notification settings - Fork 135
feat: add metadata field to scores #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidmc971 - looks good to me, left to minor comments :)
Great, thank you! Will implement those shortly :) |
Just FYI, these failing tests are expected:
There was no OSS release of the server changes yet, such that these test suites are failing because the backend doesn't handle metadata for them. Locally the tests were confirmed to be working. |
Important
Add optional
metadata
field to score-related models and methods for enhanced contextual data support.metadata
field toScoreBody
inscore_body.py
.metadata
field toCreateScoreRequest
increate_score_request.py
andBaseScore
inbase_score.py
.metadata
field toScore_Numeric
,Score_Categorical
, andScore_Boolean
inscore.py
.metadata
field to responses inget_scores_response_data.py
.score()
function inclient.py
to includemetadata
parameter.test_core_sdk.py
to includemetadata
in score creation and validation.This description was created by
for 876ecec. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR uniformly introduces an optional metadata field across score-related models and methods for enhanced contextual data support.
/langfuse/api/resources/ingestion/types/score_body.py
./langfuse/api/resources/score/types/create_score_request.py
and BaseScore in/langfuse/api/resources/commons/types/base_score.py
./langfuse/api/resources/commons/types/score.py
and responses in/langfuse/api/resources/score/types/get_scores_response_data.py
./langfuse/client.py
and corresponding tests in/tests/test_core_sdk.py
to reflect the changes.💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!