fix(client): some minor code fixes... #1176
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fix default mutable arguments, improve exception handling, and add missing class method decorator in various files.
create_prompt()
,update_prompt()
,observe_llama_index()
, andget_llama_index_handler()
inclient.py
by setting default toNone
and initializing inside the function.jsonable_encoder()
injsonable_encoder.py
by directly initializing theerrors
list with the caught exception.@classmethod
decorator toflush()
inopenai.py
.generate_error_message_fern()
andhandle_fern_exception()
to useException
instead ofError
inparse_error.py
.exclude
toNone
inauto_decorate_methods_with()
inerror_logging.py
.This description was created by
for ec01658. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR improves code quality and type safety in the Langfuse Python SDK by addressing mutable default arguments and enhancing error handling.
client.py
by changing empty lists/dicts toNone
in methods likecreate_prompt()
andupdate_prompt()
@classmethod
decorator toflush()
inlangfuse/openai.py
for proper class method behaviorjsonable_encoder.py
by directly initializing errors list with caught exceptionsError
toException
inparse_error.py
for more flexible error handlingexclude
toNone
inerror_logging.py
to avoid mutable default argument issuesThe changes follow Python best practices by preventing shared state issues with mutable defaults while maintaining existing functionality.
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!