feat: add support for external Key Vault certificate#25
Draft
nhoelterhoff wants to merge 2 commits into
Draft
Conversation
This change allows users to bring their own SSL certificate from an external Azure Key Vault instead of relying on the self-signed certificate created by the module.
Changes:
- Add `ssl_certificate_secret_id` variable to accept external certificate secret ID
- Make self-signed certificate creation conditional based on variable
- Update Application Gateway to use external or internal certificate via local
- Maintain backward compatibility (defaults to self-signed if not provided)
Users can now pass their own certificate from an external Key Vault:
```hcl
module "langfuse" {
source = "..."
ssl_certificate_secret_id = "https://my-keyvault.vault.azure.net/secrets/my-cert"
# ... other variables
}
```
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
|
When we can have in the main module @Steffen911 because it has been here for a long time. I did also my own implementation for now but it would be great to finally have it officially. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using an external Azure Key Vault certificate instead of the self-signed certificate created by the module. This allows users to bring their own SSL certificates from their own Key Vault.
ssl_certificate_secret_idvariable to accept external certificate secret IDUse Case
Users can now pass their own certificate from an external Key Vault:
The Application Gateway managed identity must have appropriate access permissions to the external Key Vault (assumes it's already whitelisted).
Testing
terraform fmtssl_certificate_secret_idis provided, module uses external certificatessl_certificate_secret_idis null (default), module creates self-signed certificate🤖 Generated with Claude Code