Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor stopping times #45

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Refactor stopping times #45

wants to merge 10 commits into from
+168 −34

Conversation

adamdempsey90
Copy link
Collaborator

Background

This does two things.

  1. Refactors our stopping times to be specialized classes following the diffusion coefficients.
  2. Adds a more sophisticated model from https://iopscience.iop.org/article/10.1088/0004-637X/806/2/203

This relies on #44 .

Closes #41 .

Description of Changes

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files

@adamdempsey90
Copy link
Collaborator Author

TODO:

  • Add new test for new model

@pdmullen pdmullen mentioned this pull request Jan 14, 2025
Merged
3 tasks
pdmullen
pdmullen reviewed Jan 14, 2025
View reviewed changes
src/drag/drag.hpp Show resolved Hide resolved
src/drag/drag.hpp Show resolved Hide resolved
src/drag/drag.hpp Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand stopping time
2 participants
@adamdempsey90 @pdmullen