[FEATURE] Allow loading mappings from paths #41
Conversation
Fluent will check the "paths" node in the doctrine config for an array of directories which it should load mapping files from
src/FluentDriver.php
Outdated
| //Set helper values to know that we have found the namespace/class token and need to collect the string values after them | ||
| $getting_namespace = $getting_class = false; | ||
|
|
||
| //Go through each token and evaluate it as necessary |
There was a problem hiding this comment.
@FoxxMD this is why I didn't add the file parser right away. Tokenizing a file's contents seems overkill, when the alternative is to list the FQCNs in the config and be done with it.
I'm not comfortable with the current solution, I don't know what @patrickbrouwers thinks about it.
There was a problem hiding this comment.
The alternative is adding 80+ lines to my doctrine config, for each manager. It gets unwieldy. Plus with paths I don't have to update my doctrine config each time I add a new mapping, just add the mapping and be done with it.
There was a problem hiding this comment.
Let me see if I can get doctrine's way to work...
Instead of tokenizing just require all files in paths and then use reflection and declared classes to find mapping classes
So all tests pass
| continue; | ||
| } | ||
|
|
||
| $sourceFile = realpath($file->getPathName()); |
|
Keeping this open as reminder, but I'd prefer a different solution. |
|
Replaced by #48 |
3 participants
Fluent will check the "paths" node in the doctrine config for an array of directories which it should load mapping files from
Changes proposed in this pull request: